Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support IDLETIME and FREQ args to RESTORE command #1685

Closed
wants to merge 1 commit into from
Closed

Add support IDLETIME and FREQ args to RESTORE command #1685

wants to merge 1 commit into from

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Mar 22, 2021 •
edited
Loading

Resolves #1683

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@codecov
Copy link

codecov bot commented Mar 22, 2021 •
edited
Loading

Codecov Report

Merging #1685 (b97b45c) into main (80b4018) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1685      +/-   ##
============================================
+ Coverage     78.31%   78.35%   +0.04%     
- Complexity     6723     6730       +7     
============================================
  Files           507      507              
  Lines         22649    22657       +8     
  Branches       2462     2464       +2     
============================================
+ Hits          17738    17754      +16     
+ Misses         3764     3760       -4     
+ Partials       1147     1143       -4
Impacted Files Coverage Δ Complexity Δ
...main/java/io/lettuce/core/RedisCommandBuilder.java 95.71% <100.00%> (+<0.01%) 535.00 <0.00> (+2.00)
src/main/java/io/lettuce/core/RestoreArgs.java 88.88% <100.00%> (+3.17%) 8.00 <2.00> (+2.00)
.../java/io/lettuce/core/protocol/CommandKeyword.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...e/core/masterreplica/SentinelTopologyProvider.java 81.08% <0.00%> (-2.71%) 9.00% <0.00%> (-1.00%)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 78.88% <0.00%> (-1.87%) 39.00% <0.00%> (-1.00%)
...ce/core/masterreplica/SentinelTopologyRefresh.java 83.22% <0.00%> (-1.30%) 36.00% <0.00%> (ø%)
...core/cluster/ClusterDistributionChannelWriter.java 79.62% <0.00%> (-0.47%) 58.00% <0.00%> (-1.00%)
src/main/java/io/lettuce/core/RedisPublisher.java 78.63% <0.00%> (-0.31%) 5.00% <0.00%> (ø%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 87.39% <0.00%> (+0.86%) 1.00% <0.00%> (ø%)
...main/java/io/lettuce/core/AbstractRedisClient.java 78.80% <0.00%> (+1.08%) 46.00% <0.00%> (+1.00%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b4018...b97b45c. Read the comment docs.

@mp911de mp911de self-assigned this Mar 26, 2021
@mp911de mp911de added the type: feature A new feature label Mar 26, 2021
@mp911de mp911de added this to the 6.1.0 milestone Mar 26, 2021
mp911de pushed a commit that referenced this pull request Mar 26, 2021
@dengliming @mp911de
Add support IDLETIME and FREQ args to RESTORE command #1683
863c19b 
Original pull request: #1685.
mp911de added a commit that referenced this pull request Mar 26, 2021
@mp911de
Polishing #1683
194b6f6 
Let RestoreArgs implement CompositeArgument. Tweak Javadoc.

Original pull request: #1685.
@mp911de
Copy link
Collaborator

mp911de commented Mar 26, 2021

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Mar 26, 2021
@dengliming dengliming deleted the restore branch March 26, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: feature A new feature
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

Add support IDLETIME and FREQ args to RESTORE command
2 participants
@dengliming @mp911de